This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Removed un-necessary allocation in assign_ops
#1085
Merged
+72
−186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecarleitao
commented
Jun 19, 2022
jorgecarleitao
commented
Jun 19, 2022
Codecov Report
@@ Coverage Diff @@
## main #1085 +/- ##
==========================================
- Coverage 81.14% 81.08% -0.06%
==========================================
Files 367 367
Lines 35316 35281 -35
==========================================
- Hits 28657 28609 -48
- Misses 6659 6672 +13
Continue to review full report at Codecov.
|
Good observation. |
ritchie46
reviewed
Jun 19, 2022
ritchie46
approved these changes
Jun 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary allocation on
assign_ops.When converting
PrimitiveArray -> MutablePrimitiveArray, we need to check that both the values and validities are unique refs. However, when operating over values and validities independently, we do not need a mutable ref to both at the same time.A common case where this was hitting was when
rhshad a validity andlhsdid not. In this case, we first cloned therhs's validity forlhs, but them tried to get a mut ref to both the validity and the values (to only use the values). This would naturally fail, causing us to have to re-use thelhs.This PR adds
PrimitiveArray::get_mut_valuesand removes (un-released) functions fromPrimitiveArray, since the functionget_mut_valuesis more generic.